Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build the list of pages only once #137

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

jammon
Copy link
Contributor

@jammon jammon commented Apr 26, 2015

Site.pages() reads the list of pages every time it is called. I don't think, that it's meant to be like that.

@krallin
Copy link
Collaborator

krallin commented Apr 26, 2015

I think this would break the cactus serve command (@koenbok did most of the work on it, so I'm not sure).

It used to work the way you're describing it, but was changed here: c297ad1

So, I'd avoid merging this for now until Koen can clarify the intention in that change.

Cheers,

@jammon
Copy link
Contributor Author

jammon commented Apr 26, 2015

Probably you are right. I found a situation (after some more code changes) that a seemingly unrelated test failed, because it relied implicitly on the files being read for every call to site.pages(). Can I take this pull request back?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants