PR: Adds the ability to set a custom ListCellRendered for the popup #49
Conversation
|
|
||
| private CheckList(JList list, CheckListRenderer customRenderer) { | ||
| if (list == null) throw new NullPointerException(); | ||
| this.list = list; |
There was a problem hiding this comment.
Probably have to check that customRenderer us not null
| this.list.getSelectionModel().setSelectionMode(ListSelectionModel.SINGLE_SELECTION); | ||
|
|
||
| if ( !isEditorAttached() ) list.addMouseListener(checkBoxEditor); | ||
| this.list.setCellRenderer(customRenderer); |
There was a problem hiding this comment.
It is better to use setCellRenderer method, since you already have it, instead of duplicating the code.
| return renderer; | ||
| } | ||
|
|
||
| public void setCheckListRenderer(ListCellRenderer renderer) { |
There was a problem hiding this comment.
This method is part of fluent interface and not a setter, so to not confuse a user I would remove the word set and leave just checkListRenderer
|
Sample usage code here |
|
There is a simple test code at https://github.com/eugener/oxbow/blob/master/swingbits/src/test/java/org/oxbow/swingbits/table/filter/TableFilterTest.java Do you think your snippet can be added there? |
|
I just realized that the feature gets served better by the useTableRenderers() method. I'm not sure it makes sense to go ahead anymore? If you feel like it's still a good thing to have I'll set up the demo code. Let me know! |
|
Closing. |
This refers to issue #48