Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(application): prevent table downgrade too small for assigned shares/assistants (#103) #108

Merged
merged 3 commits into from
Feb 14, 2025
Merged

feat(application): prevent table downgrade too small for assigned shares/assistants (#103) #108

merged 3 commits into from
Feb 14, 2025

Conversation

SharkyTheWhite
Copy link
Member

Closes #103

@SharkyTheWhite SharkyTheWhite added enhancement New feature or request APPLICATION-Phase Issues that have to be done before the Application-Phase starts labels Feb 13, 2025
@SharkyTheWhite SharkyTheWhite added this to the EF29 milestone Feb 13, 2025
Fenrikur
Fenrikur approved these changes Feb 14, 2025
View reviewed changes
Copy link
Member

@Fenrikur Fenrikur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Fenrikur Fenrikur merged commit ccafbe7 into main Feb 14, 2025
1 check passed
@Fenrikur Fenrikur deleted the feature/103-prevent-table-downgrade-overcommit branch February 14, 2025 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fenrikur Fenrikur Fenrikur approved these changes

Assignees
No one assigned
Labels
APPLICATION-Phase Issues that have to be done before the Application-Phase starts enhancement New feature or request
Projects
None yet
Milestone
EF29
Development

Successfully merging this pull request may close these issues.

Prevent dealers from downgrading to table size leading to overcommitment
2 participants
@SharkyTheWhite @Fenrikur