Initial support for BtVS: Chaos Bleeds (Xbox) #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reading the data size for Chaos Bleeds textures seemingly always returns a value of 88, which is obviously incorrect. The calculated size **must** be used instead. This adds an additional condition for Chaos Bleeds (`!(version == 170 && platform == Platform::Xbox)`) when deciding whether the `data_size` field should be included in `EXGeoTexture`. Disabling this field for Chaos Bleeds allows textures to be properly extracted.
Swyter
approved these changes
Apr 9, 2024
|
Yeah I'm happy to squash the readme changes. I wasn't sure whether you'd just squash and merge anyway, so I left it as-is for the time being. I'll do that now. |
|
@cohaereo seems busy, hope they don't mind me merging the few lines this entails. Thanks for squashing, Josh. |
|
No worries, thanks for merging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the small special case changes needed to provide initial support for Buffy The Vampire Slayer: Chaos Bleeds. This has thus far been tested only against the Xbox version of the game.
Enables extraction of meshes and textures, allowing entities to be fully extracted, but currently does not support full extraction of maps (similar to Sphinx and the Shadow of Set Demo Disc and Sphinx and the Cursed Mummy). Spreadsheets are currently untested.