warn misisng color names #558
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for contributing jskeus documentation PDF version of Japanese jmanual: jmanual.pdf |
Affonso-Gui
reviewed
Nov 13, 2019
irteus/irtgl.l
Outdated
| @@ -460,7 +460,7 @@ | |||
| ((symbolp color) | |||
| (setq c (find-if #'(lambda (o) (eq (send o :name) color)) | |||
| *face-colors*)) | |||
| (if c (send c :diffuse) (warn "Color name not found "))) | |||
| (if c (send c :diffuse) (warn "Color name (~A) not found " color))) | |||
There was a problem hiding this comment.
Maybe also add a new line after the message?
k-okada
force-pushed
the
fix_color_warning
branch
from
02d2613 to
712e8be
Compare
Affonso-Gui
approved these changes
Nov 15, 2019
|
Thank you for contributing jskeus documentation PDF version of Japanese jmanual: jmanual.pdf |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Color name not founddid not tell us which color is not found....