Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add simple Brickpi3 example #50

Merged
merged 4 commits into from
Mar 20, 2020
Merged

Add simple Brickpi3 example #50

merged 4 commits into from
Mar 20, 2020

Conversation

WasabiFan
Copy link
Member

@WasabiFan WasabiFan requested a review from dlech March 19, 2020 02:28
dlech
dlech reviewed Mar 19, 2020
View reviewed changes
Copy link
Member

@dlech dlech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good thinking with the links. Just a few comments...

platform/brickpi3-motor-and-sensor.py Outdated Show resolved Hide resolved
platform/brickpi3-motor-and-sensor.py Show resolved Hide resolved
platform/brickpi3-motor-and-sensor.py Show resolved Hide resolved
WasabiFan and others added 2 commits March 18, 2020 20:56
@WasabiFan
minor updates
068078b
@dlech
Update brickpi3-motor-and-sensor.py
c26b218 
`set_device` on output port is not supported
@dlech
Copy link
Member

dlech commented Mar 19, 2020

Works for me 😄

I added a change since set_device on the output port caused an error, hope that is OK.

@dlech dlech self-requested a review March 19, 2020 22:30
@WasabiFan
Copy link
Member Author

Oh, that's rather interesting! set_device on my EV3 worked without error while the sensor one didn't. As long as it works now I'm happy.

@WasabiFan WasabiFan merged commit 1d5b651 into stretch Mar 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dlech dlech dlech approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BrickPi3 example
2 participants
@WasabiFan @dlech