Skip to content

Fix: Remove parallel_tool_calls from OpenAI model provider for 'o' model compatibility #164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
evalstate merged 3 commits into from
May 13, 2025
Merged

Fix: Remove parallel_tool_calls from OpenAI model provider for 'o' model compatibility #164

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a20a75b
Fix: Remove parallel_tool_calls from OpenAI provider for O3 model com…
kikiya May 13, 2025
f01dcb3
Merge branch 'main' into pr/kikiya/164
evalstate May 13, 2025
49bf8b8
fix parallel_tool_calls - keep functionality for non-reasoning models
evalstate May 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions src/mcp_agent/llm/providers/augmented_llm_openai.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ def __init__(self, provider: Provider = Provider.OPENAI, *args, **kwargs) -> Non
self._reasoning_effort = self.context.config.openai.reasoning_effort

# Determine if we're using a reasoning model
# TODO -- move this to model capabiltities, add o4.
# TODO -- move this to model capabilities, add o4.
chosen_model = self.default_request_params.model if self.default_request_params else None
self._reasoning = chosen_model and (
chosen_model.startswith("o3") or chosen_model.startswith("o1")
Expand Down Expand Up @@ -325,7 +325,7 @@ async def post_tool_call(
return result

def _prepare_api_request(
self, messages, tools, request_params: RequestParams
self, messages, tools: List[ChatCompletionToolParam] | None, request_params: RequestParams
) -> dict[str, str]:
# Create base arguments dictionary

Expand All @@ -345,9 +345,8 @@ def _prepare_api_request(
)
else:
base_args["max_tokens"] = request_params.maxTokens

if tools:
base_args["parallel_tool_calls"] = request_params.parallel_tool_calls
if tools:
base_args["parallel_tool_calls"] = request_params.parallel_tool_calls

arguments: Dict[str, str] = self.prepare_provider_arguments(
base_args, request_params, self.OPENAI_EXCLUDE_FIELDS.union(self.BASE_EXCLUDE_FIELDS)
Expand Down
Loading