Review extended thinking implementation #576
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add comprehensive support for Anthropic's Extended Thinking feature: - Add ThinkingBlock, ThinkingDelta, and related type imports - Add thinking_enabled and thinking_budget_tokens config options - Update model database with anthropic_thinking reasoning mode for Claude 4+ - Handle ThinkingDelta streaming with is_reasoning=True - Store thinking segments in REASONING channel for UI display - Store raw thinking blocks for tool use passback (API verification) - Add interleaved-thinking-2025-05-14 beta header for tool use - Update multipart converter to preserve thinking blocks in assistant messages - Extract thinking_tokens in usage tracking - Handle structured output mutual exclusivity (thinking disabled) Extended thinking enables Claude to show step-by-step reasoning while maintaining compatibility with tool use through interleaved thinking.
Replace the two-field config (thinking_enabled + thinking_budget_tokens) with a single thinking_budget_tokens field where: - None = disabled (default) - >= 1024 = enabled with that budget This matches Anthropic's API model more closely - you either don't send the thinking parameter or you send it with a budget. The awkward states like "enabled but no budget" or "budget set but disabled" are eliminated. Also adds warnings for: - Budgets below 1024 (auto-corrected to minimum) - Budgets above 32K (may cause timeouts per Anthropic docs)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.