Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corrected Italian translation #22

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

mikyll
Copy link

@mikyll mikyll commented Oct 19, 2022

I've corrected some entry of the Italian translation.

I have just one doubt left, since I can't find the reference inside the game: what is the meaning of the "shell" and what are you referring to? (line 45 of file strings/english.txt)


PS: the game is amazing and I love it! :)

@mikyll mikyll changed the title Corrected Italian translations Corrected Italian translation Oct 20, 2022
@evanbowman
Copy link
Owner

@mikyll
I mean shells in this context: https://en.wikipedia.org/wiki/Shell_(projectile)

@evanbowman
Copy link
Owner

evanbowman commented Oct 20, 2022

Thank you for your changes! Before merging the pull request, I will need to test the game after changing the translation, mainly to make sure that the text still fits on the screen. I'll try to work on it soon, but it may be a couple of days before I can get to it

@mikyll
Copy link
Author

mikyll commented Oct 20, 2022

@evanbowman
I think in that case the best way to translate shells is munizioni (which I prefer rather than cartucce because the latter refers to just small calibers and I also think it sounds worse), however I've corrected it and made other little changes which I didn't notice while editing the first time.

Feel free to let me know if there's any problem or some entry that doesn't fit anymore in the game, I'd love to help you out :)

Un generatore portatile di porte iperspaziali... pensalo come... una sorta di polizza assicurativa se sei stordito.
Oh, quella vecchia cosa? Eh, non me ne faccio niente.
Un turbocompressore per un blaster, heh, piuttosto distruttivo a distanza ravvicinata.
Non sono così sicuro di cosa faccia questa cosa, sembra un vecchio orologio da taschino. Però il metallo è lavorato in modo fine, vale un sacco di soldi...
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Non sono così sicuro di cosa faccia questa cosa, sembra un vecchio orologio da taschino. Però il metallo è lavorato in modo fine, vale un sacco di soldi...
Non sono così sicuro di cosa faccia questa cosa, sembra un vecchio orologio da taschino. Però il metallo è finemente lavorato, vale un sacco di soldi...

@evanbowman
Copy link
Owner

Thanks for reviewing and for everyone's work on this! There are just one or two places in the file where trailing whitespace was added to or removed from some lines. Understand that the code will recenter text based on the length of strings in the translation, so newly added trailing spaces may result in changes to text alignment. Similarly, if any trailing whitespace was removed from the file, some text may end up concatenated with other text without proper spacing. I didn't see too many issues in the diff, maybe one or two lines. I'll take another look later. Then, I'll merge the translation and post an updated rom.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants