Skip to content

Update LumberjackSortAndSummaryExtension.php #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sunnysideup wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Update LumberjackSortAndSummaryExtension.php #3

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4558623
Update LumberjackSortAndSummaryExtension.php
sunnysideup Aug 23, 2021
7bfdf0e
PATCH: cleanup
sunnysideup Feb 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 10 additions & 7 deletions src/LumberjackSortAndSummaryExtension.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,15 +26,18 @@ public function getLumberjackPagesForGridField($excluded = [])
return parent::getLumberjackPagesForGridField();
}

// this will change the tab title
public function getLumberJackTitle()
public function getLumberjackTitle()
{
$childClasses = $this->getChildClassesOtherThanSiteTree();

if (count($childClasses) === 1) {
return Config::inst()->get($childClasses[0], 'plural_name');
$children = $this->getChildClassesOtherThanSiteTree();
$names = [];
if(is_array($children) && count($children)) {
foreach($children as $childClassName) {
if($childClassName !== Page::class) {
$names[] = Injector::inst()->get($childClassName)->i18n_plural_name();
}
}
}
return parent::getLumberjackTitle();
return count($names) ? implode(', ', $names) : parent::getLumberjackTitle();
}

private function getChildClassesOtherThanSiteTree()
Expand Down