Repository navigation
Made Cloudflare samples more idiomatic - #217
Merged
Merged
Conversation
oskardudycz
added
enhancement
The initial version from #213 was fine because it worked and used Pongo, Hono, and Emmett wrappers. Still, it wasn't perfect, as it included a lot of boilerplate that we can and should remove when using Pongo and Emmett idiomatically. It wasn't showcasing the real benefit of using them. **Note:** There'll be a follow-up PR with changes once Pongo and Emmett are polished and we address some rough edges in this usage.
oskardudycz
force-pushed
the
idiomatic_cloudflare_samples
branch
from
September 20, 2026 08:28
8d4c218 to
c65f8aa
Compare
added 3 commits
September 20, 2026 10:37
Previously it was just returning no-content, which was maybe fine from the HTTP perspective, but effectively, as some stuff like total amount are calculated on server, then cannot be assumed from the UI, without returning them one would need to follow location to get the current totals, which could return newer version than needed.
…d after Emmett improvements
|
@oskardudycz You are on fire! Thank you! |
|
I know it's to late, but i've reviewed the changes anyway. LGTM |
Contributor
Author
Thanks, see this event-driven-io/emmett#403 😀 |
Contributor
Author
It's never too late, I can always retrofit your comments if you have some. Thank you for having a look 🙂 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The initial version from #213 was fine because it worked and used Pongo, Hono, and Emmett wrappers.
Still, it wasn't perfect, as it included a lot of boilerplate that we can and should remove when using Pongo and Emmett idiomatically. It wasn't showcasing the real benefit of using them.
Note: There'll be a follow-up PR with changes once Pongo and Emmett are polished and we address some rough edges in this usage.
@dawidhermann @EisenbergEffect @SamHatoum FYI