Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Chore] Support Angular v17 (Nx v18.3.5) #8546

Closed
wants to merge 287 commits into from

Conversation

rahul-rocket
Copy link
Collaborator

@rahul-rocket rahul-rocket commented Nov 15, 2024

PR

Please note: we will close your PR without comment if you do not check the boxes above and provide ALL requested information.


Copy link
Contributor

coderabbitai bot commented Nov 15, 2024

Important

Review skipped

More than 25% of the files skipped due to max files limit. The review is being skipped to prevent a low-quality review.

139 files out of 300 files are above the max files limit of 75. Please upgrade to Pro plan to get higher limits.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

gitguardian bot commented Nov 15, 2024

⚠️ GitGuardian has uncovered 15 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
11719210 Triggered Nx Cloud Token 0b211cf nx.json View secret
11719210 Triggered Nx Cloud Token 588d302 nx.json View secret
11719210 Triggered Nx Cloud Token 588d302 nx.json View secret
11719210 Triggered Nx Cloud Token 2ab01e2 nx.json View secret
11719210 Triggered Nx Cloud Token 2ab01e2 nx.json View secret
11719210 Triggered Nx Cloud Token 9092507 nx.json View secret
11719210 Triggered Nx Cloud Token 9092507 nx.json View secret
11719210 Triggered Nx Cloud Token a99a129 nx.json View secret
11719210 Triggered Nx Cloud Token a99a129 nx.json View secret
11719210 Triggered Nx Cloud Token 8f96e72 nx.json View secret
11719210 Triggered Nx Cloud Token 8f96e72 nx.json View secret
11719210 Triggered Nx Cloud Token 20bc6da nx.json View secret
11719210 Triggered Nx Cloud Token 20bc6da nx.json View secret
11719210 Triggered Nx Cloud Token 96a9d35 nx.json View secret
11719210 Triggered Nx Cloud Token 96a9d35 nx.json View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Copy link

socket-security bot commented Nov 15, 2024

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

View full report↗︎

@rahul-rocket rahul-rocket self-assigned this Nov 15, 2024
Copy link

nx-cloud bot commented Nov 15, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 7472935. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 38 targets

Sent with 💌 from NxCloud.

rahul-rocket and others added 29 commits December 15, 2024 14:11
[Fix] Users Can Add Duplicate Employee Level && Duplicate Positions
[Fix] Unable to remove selection when user use “Select All” Option in …
 [Fix] Work End Date Can Be Set Before Work Start Date
* feat: improve employee setting entity and migration

* fix(deepscan): unused import

* feat: add employee setting subscriber

* feat: employee setting create and update services

* feat: employee setting commands

* feat: employee setting API

* fix: employee setting creation

* fix: include tenant in base entity enum

* fix: postgres migration for employee setting

* fix: SQLite employee setting migration

* fix: SQLite and MySQL employee setting migration

* fix: employee setting migration

* fix: setting type storing int values

* fix: env vars

* fix: .env.local
[Fix] Filters Not Working on “Time Off” Screen (CARDS_GRID Layout)
@evereq evereq closed this Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants