Conversation
This job cannot deploy a platform-managed Work, and fails on every push trying:
* our self-hosted ARC runners have NO egress to the cluster API — verified
from a runner pod: 192.168.1.210/.244/.170:6443 and .231/.251/.180:80 are
all unreachable, including ever-k8s' OWN api server; and
* a customer repo runs on GitHub-hosted runners, which can never reach a
private RFC1918 endpoint such as https://192.168.1.244:6443 at all.
docs/features/k8s-deployment.md already specifies the intended design for the
customer default: "k8s-works-shared — No cluster credentials to manage; the
platform runs it for you." The platform holds the kubeconfigs
(EVER_WORKS_K8S_WORKS_KUBECONFIG / _SHARED_) and runs inside the network, so
server-side apply via the existing KubernetesPlugin.deploy() is the path that
works for us AND for customers — and it never hands a cluster credential to a
repo.
Gated, not deleted (no-removal rule). A fork pointing at its OWN reachable
cluster is a legitimate use, so set GHA_K8S_DEPLOY_ENABLED=true to re-enable —
same shape as DO_ENABLED for the DigitalOcean steps. Unset everywhere in our
orgs, so this now skips instead of failing.
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Greptile SummaryAdds an explicit opt-in gate to the Kubernetes GitHub Actions deployment job. Deployments now run only when The deployment condition was executed against both supported workflow entry points. With the variable unset, Confidence Score: 5/5
What T-Rex did
Reviews (1): Last reviewed commit: "ci(k8s): gate the GitHub Actions deploy ..." | Re-trigger Greptile |
Cascades the GHA_K8S_DEPLOY_ENABLED gate to
stageso it reaches the 14 Work repos via the platform's force-push sync.