Skip to content

chore(cascade): gate GHA k8s deploy → stage - #1001

Merged
evereq merged 1 commit into
stagefrom
develop
Jul 30, 2026
Merged

chore(cascade): gate GHA k8s deploy → stage#1001
evereq merged 1 commit into
stagefrom
develop

Conversation

@evereq

@evereq evereq commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

Cascades the GHA_K8S_DEPLOY_ENABLED gate to stage so it reaches the 14 Work repos via the platform's force-push sync.

This job cannot deploy a platform-managed Work, and fails on every push trying:

  * our self-hosted ARC runners have NO egress to the cluster API — verified
    from a runner pod: 192.168.1.210/.244/.170:6443 and .231/.251/.180:80 are
    all unreachable, including ever-k8s' OWN api server; and
  * a customer repo runs on GitHub-hosted runners, which can never reach a
    private RFC1918 endpoint such as https://192.168.1.244:6443 at all.

docs/features/k8s-deployment.md already specifies the intended design for the
customer default: "k8s-works-shared — No cluster credentials to manage; the
platform runs it for you." The platform holds the kubeconfigs
(EVER_WORKS_K8S_WORKS_KUBECONFIG / _SHARED_) and runs inside the network, so
server-side apply via the existing KubernetesPlugin.deploy() is the path that
works for us AND for customers — and it never hands a cluster credential to a
repo.

Gated, not deleted (no-removal rule). A fork pointing at its OWN reachable
cluster is a legitimate use, so set GHA_K8S_DEPLOY_ENABLED=true to re-enable —
same shape as DO_ENABLED for the DigitalOcean steps. Unset everywhere in our
orgs, so this now skips instead of failing.
@evereq
evereq merged commit 7e237a8 into stage Jul 30, 2026
8 of 12 checks passed
@cursor

cursor Bot commented Jul 30, 2026

Copy link
Copy Markdown

Bugbot is not enabled for your account, so this pull request was not reviewed.

Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs.

@coderabbitai

coderabbitai Bot commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 898c6ef4-d584-4fbd-8ced-0c95d2648a89

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@greptile-apps

greptile-apps Bot commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

Adds an explicit opt-in gate to the Kubernetes GitHub Actions deployment job. Deployments now run only when GHA_K8S_DEPLOY_ENABLED is exactly true, preventing platform-managed repositories from attempting Kubernetes access from runners that cannot reach the cluster.

The deployment condition was executed against both supported workflow entry points. With the variable unset, workflow_dispatch and workflow_call both skip the job; with true, both schedule it; and TRUE remains disabled. This matches the documented server-side platform deployment model while retaining an opt-in path for forks that manage a reachable cluster.

Confidence Score: 5/5

T-Rex T-Rex Logs

What T-Rex did

  • Ran the pre-check script k8s-job-gate-01-before.py from /home/user/repo and it exited with code 0.
  • Observed that an absent variable skipped workflow_dispatch and workflow_call, while exact true was scheduled for both and TRUE was skipped, indicating the gate behaves as documented under the platform-managed deployment contract.

View all artifacts

T-Rex Ran code and verified through T-Rex

Reviews (1): Last reviewed commit: "ci(k8s): gate the GitHub Actions deploy ..." | Re-trigger Greptile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant