Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DEVPROD-4798 remove sshKey/keys fields #57

Merged
merged 2 commits into from
Apr 17, 2024
Merged

DEVPROD-4798 remove sshKey/keys fields #57

merged 2 commits into from
Apr 17, 2024

Conversation

ybrill
Copy link
Contributor

@ybrill ybrill commented Apr 16, 2024

DEVPROD-4798

Description

Should be the last PR for this ticket. These fields were removed by evergreen-ci/evergreen#7713.
This PR is a yarn codegen to keep them in sync.

Testing

local-evergreen/yarn dev works

Evergreen PR

evergreen-ci/evergreen#7713

@ybrill ybrill requested a review from a team April 16, 2024 20:55
khelif96
khelif96 approved these changes Apr 16, 2024
View reviewed changes
Copy link
Contributor

@khelif96 khelif96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for following up with this!
Can you also run yarn codegen in apps/parsley as well?

@minnakt minnakt added the spruce label Apr 16, 2024
@ybrill
Copy link
Contributor Author

ybrill commented Apr 17, 2024

I always forget about Parsley 😓 .
Why is it they each have a separate copy of the schema?

@ybrill ybrill requested a review from khelif96 April 17, 2024 14:55
khelif96
khelif96 approved these changes Apr 17, 2024
View reviewed changes
Copy link
Contributor

@khelif96 khelif96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They are still 2 distinct codebases but we will be consolidating them soon! Thanks @ybrill

@ybrill ybrill merged commit 485a632 into main Apr 17, 2024
5 checks passed
@ybrill ybrill deleted the DEVPROD-4798_remove_ssh_keys_2 branch April 17, 2024 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khelif96 khelif96 khelif96 approved these changes

Assignees
No one assigned
Labels
spruce
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ybrill @khelif96 @minnakt