Fix useHover for edge-case where multiple onMouseEnter events are fired #101
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When multiple onMouseEnter/onMouseExit events are fired (e.g., from original target + a child element) and you have a entry and/or exit delay an active timeout will be overwritten by the second one. This breaks all logic that later unsets that timeout.
This issue leads to tooltips staying open when they shouldn't and erratic behaviours around timeouts including re-opening tooltips.
This PR fixes this edge-case behaviour by explicitly ignoring secondary enter/exit events.
This doesn't apply to touch-events, as these don't have timeouts and thus secondary such events can't overwrite previous ones as the state is final.