harden(audit): apply the URL policy to sitemap discovery fetches - #192
Open
eeshsaxena wants to merge 1 commit into
Open
harden(audit): apply the URL policy to sitemap discovery fetches#192eeshsaxena wants to merge 1 commit into
eeshsaxena wants to merge 1 commit into
Conversation
Sitemap URLs come from the target's robots.txt (robots.getSitemaps) and from nested <sitemap><loc> entries, so they are attacker-controlled, but fetchSitemapDocumentWithRetry fetched them without the isCrawlableUrl check that start URLs and mid-crawl links already go through. Apply the same policy here so a sitemap can't point the crawler at private/loopback/metadata addresses. Every sitemap (including nested ones) is fetched through this function, so one check covers the whole path.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Sitemap URLs discovered during an audit come from the target's
robots.txt(robots.getSitemaps()) and from nested<sitemap><loc>entries, so they are controlled by the audited site rather than by us.fetchSitemapDocumentWithRetryfetched them after onlynormalizeUrl, without theisCrawlableUrlpolicy check that start URLs (normalizeAndValidateStartUrl) and mid-crawl links (siteAuditWorkflowCrawl) already pass through.Change
Apply
isCrawlableUrlat the top offetchSitemapDocumentWithRetry, before the fetch. Every sitemap, including nested ones (which are re-fetched through the same function), passes this single check, so a sitemap can't point the crawler at private / loopback / metadata hosts.isCrawlableUrlis already covered byurl-policy.test.ts.Keeps the URL policy consistent across all three fetch entry points (start URL, mid-crawl links, and sitemap discovery).