move managers #1328
Merged
move managers #1328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Liraim
reviewed
Nov 7, 2024
src/evidently/ui/api/projects.py
Outdated
| project: Annotated[Project, Dependency()], | ||
| # snapshot_id: Annotated[SnapshotID, Parameter(title="id of snapshot")], | ||
| ): | ||
| snapshot_id = request.path_params["snapshot_id"] |
There was a problem hiding this comment.
You should have access to snapshot_id from request parameters as in route_handler.
There was a problem hiding this comment.
path parameters are not passed to dependencies of route_handler, I tried to do this initially
| snapshot_id: Annotated[SnapshotID, Parameter(title="id of snapshot")], | ||
| project_manager: Annotated[ProjectManager, Dependency(skip_validation=True)], | ||
| log_event: Callable, | ||
| user_id: UserID, | ||
| ) -> None: | ||
| await project_manager.delete_snapshot(user_id, project_id, snapshot_id) | ||
| await project_manager.delete_snapshot(user_id, project.id, snapshot_id) |
There was a problem hiding this comment.
We are retrieving whole project from dependency to only use project_id (that available from request itself).
This would create unnecessary calls (in comparison to original version).
There was a problem hiding this comment.
It also validates if project exists and that you have access to it. Thats why I did it like this, before we didn't have those checks
# Conflicts: # src/evidently/ui/base.py
# Conflicts: # src/evidently/ui/base.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.