-
Notifications
You must be signed in to change notification settings - Fork 14
required Ruby 2.7, add new CI workflow with graphql-ruby master branch #14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
prog-supdex
wants to merge
2
commits into
evilmartians:master
Choose a base branch
from
prog-supdex:add_new_workflow
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,69 @@ | ||
name: Edge Build | ||
|
||
on: | ||
push: | ||
branches: [ master ] | ||
pull_request: | ||
schedule: | ||
- cron: "10 4 * * */2" | ||
|
||
jobs: | ||
edge-test: | ||
runs-on: ubuntu-latest | ||
env: | ||
BUNDLE_JOBS: 4 | ||
BUNDLE_RETRY: 3 | ||
BUNDLE_GEMFILE: gemfiles/graphql_master.gemfile | ||
DATABASE_URL: postgres://postgres:postgres@localhost:5432 | ||
ELASTICSEARCH_URL: http://localhost:9200 | ||
CI: true | ||
strategy: | ||
fail-fast: false | ||
matrix: | ||
ruby: [ '3.0', '3.1', '3.2', head ] | ||
services: | ||
postgres: | ||
image: postgres:13 | ||
ports: ["5432:5432"] | ||
env: | ||
POSTGRES_PASSWORD: postgres | ||
options: >- | ||
--health-cmd pg_isready | ||
--health-interval 10s | ||
--health-timeout 5s | ||
--health-retries 5 | ||
|
||
elasticsearch: | ||
image: elasticsearch:7.12.1 | ||
ports: | ||
- 9200:9200 | ||
env: | ||
ES_JAVA_OPTS: -Xms64m -Xmx256m | ||
discovery.type: single-node | ||
http.cors.enabled: "true" | ||
bootstrap.memory_lock: "true" | ||
options: >- | ||
--health-cmd "curl http://localhost:9200/_cluster/health" | ||
--health-interval 10s | ||
--health-timeout 5s | ||
--health-retries 10 | ||
steps: | ||
- uses: actions/checkout@v4 | ||
- name: Install system deps | ||
run: | | ||
sudo apt-get update | ||
sudo apt-get -yqq install libpq-dev | ||
- uses: ruby/setup-ruby@v1 | ||
with: | ||
ruby-version: ${{ matrix.ruby }} | ||
bundler-cache: true | ||
- name: Create DB | ||
run: | | ||
env PGPASSWORD=postgres createdb -h localhost -U postgres graphql_paging | ||
- name: Run Standard commands | ||
run: | | ||
bundle exec standardrb | ||
- name: Run RSpec | ||
run: | | ||
bundle exec rspec -f d --force-color | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -3,7 +3,7 @@ | |
/_yardoc/ | ||
/coverage/ | ||
/doc/ | ||
/gemfiles/ | ||
/gemfiles/*.lock | ||
/pkg/ | ||
/spec/reports/ | ||
/tmp/ | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1 @@ | ||
ruby_version: 2.6 | ||
ruby_version: 2.7 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
source "https://rubygems.org" | ||
|
||
gem "graphql", github: "rmosolgo/graphql-ruby" | ||
|
||
gemspec path: ".." |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we need these two? The setup must be similar to
ruby.yml
, the only difference is the Gemfile.And I'm not sure we need to extract this into a separate workflow; it can be another parameter in the
ruby.yml
matrix.Also,
ruby_edge
is a confusing name; we're not testing against edge Ruby but graphql gem.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because in the matrix we put "head" ruby (for master ruby), and this ruby version puts
RUBY_VERSION
to the docker file through env (it is default, like ci cd looks for ruby.yml).So Docker doesn't know about the "head" ruby version.
Also, I couldn't find the image with the master ruby
About naming - OK, agree