fix: support empty nodes #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrexox
force-pushed
the
fix/support-empty-nodes
branch
from
987b3db to
306bbef
Compare
|
@prog-supdex , hey! Could you take a look at this change? Does it feel OK? |
DmitryTsepelev
approved these changes
Nov 7, 2023
.github/workflows/ruby.yml
Outdated
| @@ -12,12 +12,12 @@ jobs: | |||
| strategy: | |||
| fail-fast: false | |||
| matrix: | |||
| ruby: [ '2.6', '2.7', '3.0' ] | |||
| ruby: [ '2.7', '3.0', '3.1', '3.2' ] | |||
There was a problem hiding this comment.
ruby 2.7 is not supported anymore, so I guess we can drop it as well
There was a problem hiding this comment.
Agree. Can you disable the status check for the PR for 2.6 and 2.7 and add 3.1 and 3.2?
There was a problem hiding this comment.
looks like I do not have a proper role 🙂
|
@bibendi, hey! Could you please take a look at this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12
Context
GraphQL::Connections::Stablefails when empty relation is passed. This PR fixes it.Related tickets
#12
What's inside
falseif nodes are emptyChecklist: