fix: execute files command within configured root #607
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Are the files passed in staged_files corrected to be relative to the defined root path? That's my pain point, had to make a gnarly shell script to chop client/ off the beginning of our paths. |
|
@jameslporter , yes, files are being filtered by |
mrexox
force-pushed
the
fix/execute-files-command-within-configured-root
branch
from
356b2f6
to
31e7834
Compare
mrexox
force-pushed
the
fix/execute-files-command-within-configured-root
branch
from
31e7834
to
98e852e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #292
馃敡 Summary
Execute
filesfrom within a configured root in case it contains a path to a script. This is a breaking change.