Skip to content

update to androguard latest & r2 python3#9

Merged
evilpan merged 7 commits intoevilpan:masterfrom
AbhiTheModder:master
Oct 16, 2024
Merged

update to androguard latest & r2 python3#9
evilpan merged 7 commits intoevilpan:masterfrom
AbhiTheModder:master

Conversation

@AbhiTheModder
Copy link
Copy Markdown
Contributor

@AbhiTheModder AbhiTheModder commented Oct 2, 2024

Updated with latest androguard and fixed r2 script (though it's useless now since r2 is able to identify them through it's analysis still xD )

Sorry for too many changes, auto-save linter did them, actual ones are (which you can review):
extract_jni.py:

r2/jni_helper.py: (though again useless)

  • print blocks & f-string formatting

minor: CI fix

* was imported for test purposes from androguard team test/ dir
Comment thread .gitignore
@evilpan evilpan merged commit e9dd18c into evilpan:master Oct 16, 2024
@evilpan
Copy link
Copy Markdown
Owner

evilpan commented Oct 16, 2024

Thanks for your commits!

@AbhiTheModder
Copy link
Copy Markdown
Contributor Author

AbhiTheModder commented Oct 16, 2024

Workflow Still seems to be failing tho, idk what's the issue with it in their migration guide it's stated they are now using pattern instead of name(though it's still there as optional) but that too doesn't seem to be working, and in case the artifect gets downloads the test gives FileNotFoundError

Edit: Aha figured it out, it no longer creates a directory, the artifact got extracted to current working directory.

@AbhiTheModder AbhiTheModder mentioned this pull request Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants