Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating descriptions and adding examples for combinators #381

Merged
merged 10 commits into from
Apr 14, 2019
Merged

Updating descriptions and adding examples for combinators #381

merged 10 commits into from
Apr 14, 2019

Conversation

dalefrancis88
Copy link
Collaborator

@dalefrancis88 dalefrancis88 commented Feb 26, 2019 •
edited
Loading

This PR is to complete the issue #380

I am going to be working on each piece however if anyone reviews and approves, i'm happy to merge with some of the items complete

@coveralls
Copy link

coveralls commented Feb 26, 2019 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling 4ffd18f on docs/combinators into 99c7f03 on master.

@evilsoft
Copy link
Owner

evilsoft commented Mar 2, 2019

Something is wrong with the linter. There are MANY linting errors in this PR. from semi-colons to double quotes. This should have failed Travis.

evilsoft
evilsoft previously requested changes Mar 2, 2019
View reviewed changes
Copy link
Owner

@evilsoft evilsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are MANY linting issues. Going to see what is going on with the linter.

docs/src/pages/docs/functions/combinators.md Outdated Show resolved Hide resolved
docs/src/pages/docs/functions/combinators.md Outdated Show resolved Hide resolved
docs/src/pages/docs/functions/combinators.md Outdated Show resolved Hide resolved
@dalefrancis88
Copy link
Collaborator Author

That's weird, i don't know how they all ended up with double quotes. I'll get it all cleaned up :/

@dalefrancis88 dalefrancis88 requested a review from evilsoft March 3, 2019 02:31
@dalefrancis88 dalefrancis88 dismissed evilsoft’s stale review March 3, 2019 19:19

review comments addressed

evilsoft
evilsoft requested changes Mar 3, 2019
View reviewed changes
Copy link
Owner

@evilsoft evilsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The imports should be alphabetized and some additional changes

docs/src/pages/docs/functions/combinators.md Outdated Show resolved Hide resolved
docs/src/pages/docs/functions/combinators.md Outdated Show resolved Hide resolved
docs/src/pages/docs/functions/combinators.md Show resolved Hide resolved
docs/src/pages/docs/functions/combinators.md Outdated Show resolved Hide resolved
docs/src/pages/docs/functions/combinators.md Outdated Show resolved Hide resolved
@dalefrancis88 dalefrancis88 requested a review from evilsoft March 6, 2019 16:22
evilsoft
evilsoft previously requested changes Mar 16, 2019
View reviewed changes
Copy link
Owner

@evilsoft evilsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple more things and I believe this is 🔴 👁️ for :shipit:

docs/src/pages/docs/functions/combinators.md Outdated Show resolved Hide resolved
docs/src/pages/docs/functions/combinators.md Show resolved Hide resolved
docs/src/pages/docs/functions/combinators.md Outdated Show resolved Hide resolved
docs/src/pages/docs/functions/combinators.md Outdated Show resolved Hide resolved
docs/src/pages/docs/functions/combinators.md Outdated Show resolved Hide resolved
@dalefrancis88 dalefrancis88 requested a review from evilsoft March 22, 2019 20:59
@dalefrancis88 dalefrancis88 dismissed evilsoft’s stale review March 22, 2019 21:00

Review addressed

evilsoft
evilsoft previously requested changes Mar 31, 2019
View reviewed changes
Copy link
Owner

@evilsoft evilsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple more things I missed on my original pass.
Sorry about that! and thanks so much for getting these examples in there.
So helpful!

docs/src/pages/docs/functions/combinators.md Outdated Show resolved Hide resolved
docs/src/pages/docs/functions/combinators.md Outdated Show resolved Hide resolved
@dalefrancis88 dalefrancis88 dismissed evilsoft’s stale review April 10, 2019 14:56

needs new review

@dalefrancis88 dalefrancis88 requested a review from evilsoft April 10, 2019 14:56
evilsoft
evilsoft approved these changes Apr 14, 2019
View reviewed changes
Copy link
Owner

@evilsoft evilsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks real nice! Thanks again for all you do!

Have a squirrel combined with an armadillo!
image

@evilsoft evilsoft merged commit 40be4e9 into master Apr 14, 2019
@evilsoft evilsoft deleted the docs/combinators branch April 14, 2019 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evilsoft evilsoft evilsoft approved these changes

@HenriqueLimas HenriqueLimas Awaiting requested review from HenriqueLimas

@bennypowers bennypowers Awaiting requested review from bennypowers

@karthikiyengar karthikiyengar Awaiting requested review from karthikiyengar

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dalefrancis88 @coveralls @evilsoft