Make useMutation mutate stable

evoluhq · Oct 25, 2022 · 15fa758 · 15fa758 · vercel · Oct 25, 2022
1 parent 3c0f43d
commit 15fa758
Show file tree

Hide file tree

Showing 3 changed files with 21 additions and 15 deletions.
diff --git a/.changeset/early-buses-shave.md b/.changeset/early-buses-shave.md
@@ -0,0 +1,5 @@
+---
+"evolu": patch
+---
+
+Make useMutation mutate stable
diff --git a/packages/evolu/src/createHooks.ts b/packages/evolu/src/createHooks.ts
@@ -48,8 +48,9 @@ export const createHooks = <S extends DbSchema>(
     };
   };
 
+  const mutate = db.createMutate<S>();
   const useMutation: UseMutation<S> = () => ({
-    mutate: db.createMutate<S>(),
+    mutate,
   });
 
   return {

diff --git a/packages/evolu/src/db.ts b/packages/evolu/src/db.ts
@@ -299,15 +299,16 @@ const createNewCrdtMessages = (
     )
   );
 
-export const createMutate = <S extends DbSchema>(): Mutate<S> => {
-  const queueRef = new ioRef.IORef<
-    readonly {
-      readonly messages: ReadonlyNonEmptyArray<NewCrdtMessage>;
-      readonly onCompleteId: Option<OnCompleteId>;
-    }[]
-  >(readonlyArray.empty);
-
-  return function mutate(table, { id, ...values }, onComplete) {
+const mutateQueueRef = new ioRef.IORef<
+  readonly {
+    readonly messages: ReadonlyNonEmptyArray<NewCrdtMessage>;
+    readonly onCompleteId: Option<OnCompleteId>;
+  }[]
+>(readonlyArray.empty);
+
+export const createMutate =
+  <S extends DbSchema>(): Mutate<S> =>
+  (table, { id, ...values }, onComplete) => {
     const isInsert = id == null;
     // eslint-disable-next-line no-param-reassign
     if (isInsert) id = createId() as never;
@@ -333,13 +334,13 @@ export const createMutate = <S extends DbSchema>(): Mutate<S> => {
         })
       );
 
-      const runQueueMicrotask = queueRef.read().length === 0;
-      queueRef.modify(readonlyArray.append({ messages, onCompleteId }))();
+      const runQueueMicrotask = mutateQueueRef.read().length === 0;
+      mutateQueueRef.modify(readonlyArray.append({ messages, onCompleteId }))();
 
       if (runQueueMicrotask)
         pipe(
-          queueRef.read,
-          io.chainFirst(() => queueRef.write([])),
+          mutateQueueRef.read,
+          io.chainFirst(() => mutateQueueRef.write([])),
           io.map(readonlyNonEmptyArray.fromReadonlyArray),
           ioOption.chainIOK((queue) =>
             postDbWorkerInput({
@@ -362,7 +363,6 @@ export const createMutate = <S extends DbSchema>(): Mutate<S> => {
 
     return { id } as never;
   };
-};
 
 export const getOwner: Task<Owner> = owner;