Skip to content

Commit

Permalink
test(esl-popup): apply suggestions from code review
Browse files Browse the repository at this point in the history
  • Loading branch information
dshovchko committed Feb 26, 2024
1 parent e118540 commit cdc8b45
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 8 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ describe('ESLPopup position: calcPopupPosition(): behavior set to fit-minor', ()
expect(calcPopupPosition(cfg)).toEqual(expected);
});

describe('when the popup has a position on the vertical axe and', () => {
describe('when the popup has a position on the vertical axis', () => {
const expected = Object.assign({}, expectedRef) as PopupPositionValue;
expected.popup = popup.shift(360, 290);
test('when the trigger is outside of the outer limiting element by the own left edge', () => {
Expand All @@ -87,7 +87,7 @@ describe('ESLPopup position: calcPopupPosition(): behavior set to fit-minor', ()
});
});

describe('when the popup has a position on the horizontal axe and', () => {
describe('when the popup has a position on the horizontal axis', () => {
const expected = Object.assign({}, expectedRef) as PopupPositionValue;
expected.popup = popup.shift(530, 410);
expected.placedAt = 'right';
Expand All @@ -102,7 +102,7 @@ describe('ESLPopup position: calcPopupPosition(): behavior set to fit-minor', ()
});
});

describe('when there is a lack of space for position adjustment on the horizontal axe:', () => {
describe('when there is a lack of space for position adjustment on the horizontal axis:', () => {
const expected = Object.assign({}, expectedRef) as PopupPositionValue;
expected.popup = popup.shift(360, 530);
expected.placedAt = 'bottom';
Expand All @@ -118,7 +118,7 @@ describe('ESLPopup position: calcPopupPosition(): behavior set to fit-minor', ()
});
});

describe('when there is a lack of space for position adjustment on the vertical axe:', () => {
describe('when there is a lack of space for position adjustment on the vertical axis:', () => {
const expected = Object.assign({}, expectedRef) as PopupPositionValue;
expected.popup = popup.shift(530, 410);
expected.placedAt = 'right';
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -138,7 +138,7 @@ describe('ESLPopup position: calcPopupPosition(): behavior set to fit-major', ()
expect(calcPopupPosition(cfg)).toEqual(expected);
});

describe('when the popup has a position on the vertical axe and', () => {
describe('when the popup has a position on the vertical axis', () => {
const expected = Object.assign({}, expectedRef) as PopupPositionValue;
expected.popup = popup.shift(360, 290);
test('when the trigger is outside of the outer limiting element by the own left edge', () => {
Expand All @@ -152,7 +152,7 @@ describe('ESLPopup position: calcPopupPosition(): behavior set to fit-major', ()
});
});

describe('when the popup has a position on the horizontal axe and', () => {
describe('when the popup has a position on the horizontal axis', () => {
const expected = Object.assign({}, expectedRef) as PopupPositionValue;
expected.popup = popup.shift(530, 410);
expected.placedAt = 'right';
Expand All @@ -167,7 +167,7 @@ describe('ESLPopup position: calcPopupPosition(): behavior set to fit-major', ()
});
});

describe('when there is a lack of space for position adjustment on the horizontal axe:', () => {
describe('when there is a lack of space for position adjustment on the horizontal axis:', () => {
const expected = Object.assign({}, expectedRef) as PopupPositionValue;
expected.popup = popup.shift(360, 530);
expected.placedAt = 'bottom';
Expand All @@ -183,7 +183,7 @@ describe('ESLPopup position: calcPopupPosition(): behavior set to fit-major', ()
});
});

describe('when there is a lack of space for position adjustment on the vertical axe:', () => {
describe('when there is a lack of space for position adjustment on the vertical axis:', () => {
const expected = Object.assign({}, expectedRef) as PopupPositionValue;
expected.popup = popup.shift(530, 410);
expected.placedAt = 'right';
Expand Down

0 comments on commit cdc8b45

Please sign in to comment.