chore(site): create lorem-ipsum custom dummy text element
#2040
Conversation
ala-n
added
site
ala-n
requested review from
yadamskaya,
abarmina and
NastaLeo
and removed request for
a team
ala-n
force-pushed
the
tech/lorem-ipsum
branch
from
b3c7bea to
c4e1198
Compare
ala-n
force-pushed
the
tech/lorem-ipsum
branch
from
544c676 to
80dec19
Compare
ala-n
changed the title
esl-d-lorem-ipsum custom elementlorem-ipsum custom element
ala-n
changed the title
lorem-ipsum custom elementlorem-ipsum custom dummy text element
|
@exadel-inc/esl-all-contributors team, there is one common question remaining for that PR: As you can see, the component is generalized enough. While it may not be a production-valuable component, it could still be utilized for demo content in the development process, not only on the ESL site but also on the customer side. So, do you think it is a good idea to move the component from the site package to ESL modules?
The default custom tag name has been set to
Feel free to express your opinion via text in case a quick vote with emojis does not clearly convey your thoughts. |
|
Code Climate has analyzed commit efeaf1c and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 54.7% (0.0% change). View more on Code Climate. |
| super.disconnectedCallback(); | ||
| } | ||
| protected override attributeChangedCallback(name: string, oldValue: string, newValue: string): void { | ||
| super.attributeChangedCallback(name, oldValue, newValue); |
There was a problem hiding this comment.
Does it need to call the empty method?
| import {ESLBaseElement} from '@exadel/esl/modules/esl-base-element/core'; | ||
| import {attr} from '@exadel/esl/modules/esl-utils/decorators'; | ||
|
|
||
| const WORDS = [ |
There was a problem hiding this comment.
I guess "dictionary" is a more appropriate name.
And it seems to me that if users could import the dictionaries they need and use them, then this would be a very cool feature. Moreover, they could make their own dictionaries and use them.
There was a problem hiding this comment.
Great idea! I'll take a look how to make this setting available
|
As a result of discussion final tag name: |
ala-n
added
not ready for merge
and removed
needs review
|
Closed as moved to #2055 |
Starting to move staff from
epic/redesignbranch to stable...