Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(esl-random-text): create auxiliary esl-random-text component to generate dummy text #2055

Merged
merged 11 commits into from
Nov 24, 2023

Conversation

ala-n
Copy link
Collaborator

@ala-n ala-n commented Nov 16, 2023

Based on #2040 draft

@ala-n ala-n marked this pull request as ready for review November 21, 2023 21:55
@ala-n ala-n added the needs review The PR is waiting for review label Nov 22, 2023
@ala-n ala-n requested review from a team, dshovchko, julia-murashko and yadamskaya and removed request for a team November 22, 2023 10:44
@ala-n ala-n removed the needs review The PR is waiting for review label Nov 22, 2023
@ala-n ala-n added the needs review The PR is waiting for review label Nov 22, 2023
src/modules/esl-random-text/README.md Outdated Show resolved Hide resolved
src/modules/esl-random-text/README.md Outdated Show resolved Hide resolved
src/modules/esl-random-text/README.md Outdated Show resolved Hide resolved
src/modules/esl-random-text/README.md Outdated Show resolved Hide resolved
@dshovchko
Copy link
Collaborator

Do we need to add to ESLLibrary types for the new component?

@ala-n
Copy link
Collaborator Author

ala-n commented Nov 23, 2023

Do we need to add to ESLLibrary types for the new component?

It's not in the window.ESL namespace for now/, in case we decide to add it globaly we will add it.
But we miss new element default in HTMLElementTagNameMap, going to fix that in an hour

Copy link

codeclimate bot commented Nov 24, 2023

Code Climate has analyzed commit 87d0747 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 0.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 54.2% (-0.5% change).

View more on Code Climate.

@ala-n ala-n merged commit fa667b7 into main Nov 24, 2023
9 checks passed
@ala-n ala-n deleted the epic/random-text branch November 24, 2023 14:26
@github-actions github-actions bot locked and limited conversation to collaborators Nov 24, 2023
@ala-n
Copy link
Collaborator Author

ala-n commented Nov 24, 2023

🎉 This PR is included in version 4.14.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@ala-n ala-n added the released label Nov 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs review The PR is waiting for review released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants