Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(gh-pages): newsline section #1731

Merged
merged 21 commits into from
Jun 29, 2023
Merged

docs(gh-pages): newsline section #1731

merged 21 commits into from
Jun 29, 2023

Conversation

fshovchko
Copy link
Contributor

In the scope of this PR, the landing page blogs section was reworked into news sections and now consists of blogs and articles.
Closes #1652

@fshovchko fshovchko added the documentation Improvements or additions to documentation label Jun 19, 2023
@fshovchko fshovchko requested a review from a team June 19, 2023 17:38
@fshovchko fshovchko self-assigned this Jun 19, 2023
@fshovchko fshovchko requested review from dshovchko, ala-n and yadamskaya and removed request for a team June 19, 2023 17:38
pages/11ty/date.filter.js Outdated Show resolved Hide resolved
Copy link
Collaborator

@ala-n ala-n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check if everything is aligned with the following spec update
#1652 (comment)

pages/11ty/date.filter.js Outdated Show resolved Hide resolved
@fshovchko fshovchko requested a review from ala-n June 23, 2023 20:19
@ala-n ala-n changed the title docs(gh-pages): news section docs(gh-pages): newsline section Jun 26, 2023
@fshovchko fshovchko requested a review from abarmina June 27, 2023 12:06
pages/11ty/markdown.shortcut.js Outdated Show resolved Hide resolved
pages/views/_includes/landing/newsline.njk Outdated Show resolved Hide resolved
@ala-n
Copy link
Collaborator

ala-n commented Jun 28, 2023

PR was revisited, and the component was updated according to initial UI/UX feedback

image

@ala-n ala-n requested review from NastaLeo and ala-n June 28, 2023 22:52
@ala-n ala-n added needs review The PR is waiting for review site Feature, enhancement or bug for demo site and removed documentation Improvements or additions to documentation labels Jun 28, 2023
@codeclimate
Copy link

codeclimate bot commented Jun 28, 2023

Code Climate has analyzed commit c8dbcb3 and detected 1 issue on this pull request.

Here's the issue category breakdown:

Category Count
Complexity 1

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 49.4% (0.0% change).

View more on Code Climate.

@ala-n ala-n changed the base branch from main to epic/redesign June 28, 2023 23:05
@@ -0,0 +1,12 @@
---
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note for reviewers: this file contains test data

@@ -0,0 +1,19 @@
---
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note for reviewers: this file contains test data

@@ -0,0 +1,9 @@
---
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note for reviewers: that one is not a stub. So feel free to make notes regarding content

Comment on lines 93 to 94
color: #fbf9a2;
border-color: #fbf9a2;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Proposition. Add this color to colors.less

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will be done separately with the final cleanup on the epic/redesign branch

@ala-n ala-n merged commit 2a8371d into epic/redesign Jun 29, 2023
6 checks passed
@ala-n ala-n deleted the docs/news-section branch June 29, 2023 15:10
@github-actions github-actions bot locked and limited conversation to collaborators Jun 29, 2023
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs review The PR is waiting for review site Feature, enhancement or bug for demo site under discussion
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[🚀gh-pages] proposal: news & articles section
5 participants