Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

epic(eslint): eslint plugin to find and replace deprecated ESL aliases #1957

Merged
merged 24 commits into from
Nov 23, 2023

Conversation

ala-n
Copy link
Collaborator

@ala-n ala-n commented Sep 25, 2023

Closes: #1283

Natalie-Smirnova and others added 2 commits September 25, 2023 23:50
…on the customer's projects (#1374)

Implements a separate npm package with an ESLint plugin to find and fix ESL library deprecations
Module declared as an ESL package workspace and going to be updated according to library build processes.
---------

Co-authored-by: ala'n (Alexey Stsefanovich) <[email protected]>
Co-authored-by: Anastasiya Lesun <[email protected]>
eslint/core/deprecated-alias.js Outdated Show resolved Hide resolved
eslint/core/deprecated-alias.js Outdated Show resolved Hide resolved
eslint/core/deprecated-alias.js Outdated Show resolved Hide resolved
@ala-n ala-n added require squash No action from PR author required. Marks that current PR will be merged with squash needs review The PR is waiting for review labels Nov 2, 2023
@ala-n ala-n marked this pull request as ready for review November 2, 2023 02:54
@ala-n ala-n requested review from a team, yadamskaya, abarmina and NastaLeo and removed request for a team November 2, 2023 03:00
Comment on lines 25 to 31
/**
* Builds deprecation rule
* @param context - AST tree object
* @param node - import node to process
* @param alias - current name
*/
export function buildRule({deprecation, alias}: ESLintDeprecationCfg): Rule.RuleModule {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TSDoc: there is an mistake in params description

@ala-n ala-n removed not ready for merge require squash No action from PR author required. Marks that current PR will be merged with squash labels Nov 23, 2023
Copy link

codeclimate bot commented Nov 23, 2023

Code Climate has analyzed commit 516bc19 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 54.7% (0.0% change).

View more on Code Climate.

@ala-n ala-n merged commit 4b1ea5f into main Nov 23, 2023
10 checks passed
@ala-n ala-n deleted the epic/eslint-rules branch November 23, 2023 20:13
@github-actions github-actions bot locked and limited conversation to collaborators Nov 23, 2023
@ala-n
Copy link
Collaborator Author

ala-n commented Nov 24, 2023

🎉 This PR is included in version 4.14.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@ala-n ala-n added the released label Nov 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs review The PR is waiting for review released
Projects
None yet
6 participants