[🚩esl-modal]: beta release version of esl-modal module #1969
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NastaLeo
requested review from
dshovchko,
ala-n and
julia-murashko
and removed request for
a team
…l-modal # Conflicts: # pages/src/localdev.ts
dshovchko
reviewed
Jan 4, 2024
Comment on lines
62
to
65
| if (!this.cache[selector]) { | ||
| this.cache[selector] = this.$fragment.querySelector(selector); | ||
| } | ||
| return this.cache[selector]; |
There was a problem hiding this comment.
I guess you missed clearing the cache in the clear() method (in row number 52).
| expect(ESLModalStack.store[1]).toBe(TEMPLATE.$modal2); | ||
| expect(ESLModalStack.store.length).toBe(2); | ||
| }); | ||
| test('Closing and removing parent modal from store leads to hide all nested modals in case their are opened before target modal closes and its removing from store', () => { |
There was a problem hiding this comment.
I think it can be simplified
Suggested change
| test('Closing and removing parent modal from store leads to hide all nested modals in case their are opened before target modal closes and its removing from store', () => { | |
| test('Removing the parent modal leads to hiding all nested modals if opened', () => { |
…ic/esl-modal # Conflicts: # site/src/localdev.ts # site/views/examples/modal.njk
ala-n
force-pushed
the
main
branch
4 times, most recently
from
df09192 to
5f44df3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #1376