chore(build): update version bumper #1990
Conversation
|
It looks like we need to revisit the approach. As was discovered in #2003 the version bumping can be handled via existing npm processes, nevertheless we still need a solution for meta information update which |
| @@ -9,7 +9,7 @@ | |||
| "test": "jest", | |||
| "clean": "rimraf dist", | |||
| "build": "npm run clean && tsc --project tsconfig.json", | |||
| "version": "node ../build/bump.js" | |||
| "version": "node ../build/bump.js $npm_package_version" | |||
There was a problem hiding this comment.
You don't need env $npm_package_version here, because
- it is already in
process.env, while mentioning it here produces problems on windows machines (out of cross-env runner) - action in version hook is executed after native npm version process so the actual version is also presented inside current package.json
| - filePath: 'package.json' | ||
| patterns: | ||
| - '"name"\s*:\s*"\@exadel\/eslint-plugin-esl"[^{}]*"version"\s*:\s*"(\d+\.\d+\.\d+)"' | ||
| - '"@exadel\/esl\": \"\^(\d+\.\d+\.\d+)\"' |
There was a problem hiding this comment.
It appears to be incorrect, as I mentioned earlier.
The native npm version processes the version section and dependencies without our interventions.
|
After a deeper investigation it appears to be that we no longer require any additional actions at all. |
After looking up the solutions for automatic version update, it was decided to enhance our own already made solution
#1529