Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(esl-popup): internal ESLPopup implementation updated to use ESLEventListeners; usage of cached properties reduced #2018

Merged
merged 2 commits into from
Nov 13, 2023

Conversation

ala-n
Copy link
Collaborator

@ala-n ala-n commented Oct 30, 2023

Closes: #2009

…ventListeners; usage of cached properties reduced
@ala-n ala-n added not ready for merge needs review The PR is waiting for review labels Oct 30, 2023
@ala-n ala-n added this to the ⚡ESL: 4.14.0 Minor release milestone Oct 30, 2023
@ala-n ala-n requested review from dshovchko, Natalie-Smirnova and a team October 30, 2023 16:37
@ala-n ala-n self-assigned this Oct 30, 2023
@ala-n ala-n requested review from abarmina and NastaLeo and removed request for a team October 30, 2023 16:37
@codeclimate
Copy link

codeclimate bot commented Oct 30, 2023

Code Climate has analyzed commit 014ebe4 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 0.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 54.7% (0.2% change).

View more on Code Climate.

@ala-n ala-n merged commit f609aa8 into main Nov 13, 2023
6 checks passed
@ala-n ala-n deleted the tech/esl-popup-cleanup branch November 13, 2023 15:28
@github-actions github-actions bot locked and limited conversation to collaborators Nov 13, 2023
@ala-n
Copy link
Collaborator Author

ala-n commented Nov 24, 2023

🎉 This PR is included in version 4.14.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@ala-n ala-n added the released label Nov 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs review The PR is waiting for review released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[🔧 esl-popup]: refactor to use esl-event-listeners
6 participants