Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(esl-event-listener): inert wheel detector #2031

Merged
merged 10 commits into from
Nov 30, 2023

Conversation

fshovchko
Copy link
Contributor

In the scope of this PR was created a script, that dispatches longwheel when long scrolls are detected
Closes #2017

@fshovchko fshovchko requested review from ala-n and abarmina November 6, 2023 19:07
@fshovchko fshovchko self-assigned this Nov 6, 2023
@fshovchko fshovchko requested review from a team and yadamskaya and removed request for a team November 6, 2023 20:06
@fshovchko fshovchko added the feature New feature label Nov 6, 2023
Copy link

codeclimate bot commented Nov 7, 2023

Code Climate has analyzed commit 32f25bb and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 0.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 54.0% (-0.3% change).

View more on Code Climate.

@ala-n
Copy link
Collaborator

ala-n commented Nov 7, 2023

We need Unit Tests, Doc, and Example to approve it for the main branch.
Let's create an epic branch to split work and unlock the current PR for review.

@ala-n ala-n changed the base branch from main to epic/wheel-target November 7, 2023 11:17
@ala-n ala-n added needs review The PR is waiting for review require squash No action from PR author required. Marks that current PR will be merged with squash labels Nov 7, 2023
@ala-n
Copy link
Collaborator

ala-n commented Nov 7, 2023

Marked as require squash to make 'feat' commit message more detailed
FYI @exadel-inc/esl-core-maintainers

@ala-n ala-n added this to the ⚡ESL: 4.14.0 Minor release milestone Nov 7, 2023
@ala-n ala-n removed the needs review The PR is waiting for review label Nov 7, 2023
@fshovchko fshovchko requested a review from ala-n November 8, 2023 13:58
@fshovchko fshovchko added the needs review The PR is waiting for review label Nov 8, 2023
@fshovchko fshovchko removed the needs review The PR is waiting for review label Nov 13, 2023
Copy link
Collaborator

@ala-n ala-n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved for the epic branch
Implementation looks really nice 👍🏻

@ala-n ala-n merged commit 4dc4bfc into epic/wheel-target Nov 30, 2023
6 checks passed
@ala-n ala-n deleted the feat/inert-wheel branch November 30, 2023 01:25
@github-actions github-actions bot locked and limited conversation to collaborators Nov 30, 2023
@ala-n
Copy link
Collaborator

ala-n commented Dec 19, 2023

🎉 This PR is included in version 5.0.0-beta.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@ala-n
Copy link
Collaborator

ala-n commented Apr 5, 2024

🎉 This PR is included in version 4.15.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@ala-n ala-n added the released label Apr 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature New feature released on @beta released require squash No action from PR author required. Marks that current PR will be merged with squash
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[🚀esl-event-listener]: request for InertWheel event detector
3 participants