-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(esl-event-listener): inert wheel detector #2031
Conversation
Code Climate has analyzed commit 32f25bb and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 0.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 54.0% (-0.3% change). View more on Code Climate. |
We need Unit Tests, Doc, and Example to approve it for the main branch. |
Marked as |
src/modules/esl-event-listener/core/targets/inert.target.event.ts
Outdated
Show resolved
Hide resolved
src/modules/esl-event-listener/core/targets/inert.target.event.ts
Outdated
Show resolved
Hide resolved
3152556
to
692c347
Compare
src/modules/esl-event-listener/core/targets/inert.target.event.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved for the epic branch
Implementation looks really nice 👍🏻
src/modules/esl-event-listener/core/targets/inert.target.event.ts
Outdated
Show resolved
Hide resolved
src/modules/esl-event-listener/core/targets/wheel.target.event.ts
Outdated
Show resolved
Hide resolved
src/modules/esl-event-listener/core/targets/wheel.target.event.ts
Outdated
Show resolved
Hide resolved
src/modules/esl-event-listener/core/targets/wheel.target.event.ts
Outdated
Show resolved
Hide resolved
src/modules/esl-event-listener/core/targets/wheel.target.event.ts
Outdated
Show resolved
Hide resolved
🎉 This PR is included in version 5.0.0-beta.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
🎉 This PR is included in version 4.15.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
In the scope of this PR was created a script, that dispatches
longwheel
when long scrolls are detectedCloses #2017