Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ESL Avatar #2052

Closed
wants to merge 28 commits into from
Closed

ESL Avatar #2052

wants to merge 28 commits into from

Conversation

dshovchko
Copy link
Collaborator

Created a new component to display users' avatar

@dshovchko dshovchko self-assigned this Nov 15, 2023
@ala-n ala-n added the needs review The PR is waiting for review label Nov 15, 2023
src/modules/esl-avatar/core/esl-avatar.less Outdated Show resolved Hide resolved
src/modules/esl-avatar/core/esl-avatar.less Outdated Show resolved Hide resolved
src/modules/esl-avatar/core/esl-avatar.less Outdated Show resolved Hide resolved
src/modules/esl-avatar/core/esl-avatar.ts Outdated Show resolved Hide resolved
src/modules/esl-avatar/core/esl-avatar.ts Outdated Show resolved Hide resolved
src/modules/esl-avatar/core/esl-avatar.ts Outdated Show resolved Hide resolved
src/modules/esl-avatar/core/esl-avatar.ts Outdated Show resolved Hide resolved
src/modules/esl-avatar/core/esl-avatar.ts Outdated Show resolved Hide resolved
@ala-n ala-n added the require squash No action from PR author required. Marks that current PR will be merged with squash label Nov 16, 2023
@ala-n
Copy link
Collaborator

ala-n commented Nov 16, 2023

Mark as require squash
Possibly we need reword [initial implementation of avatar component](https://github.com/exadel-inc/esl/pull/2052/commits/41ca919bcf08749054bb509c87eb2201378dac94) as the user does not expect to see initial (it is expected to see ready result, released or beta)

@ala-n ala-n added this to the ⚡ESL: 5.0.0 Major release milestone Nov 20, 2023
/** Policy of loading image that is outside of the viewport */
loading?: 'eager' | 'lazy';
/** The limit number of letters to be displayed in text-only mode */
'abbr-length'?: number;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cosmetic to follow consistency in syntax:
abbr-length?: number;

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

must be in quote marks

@dshovchko
Copy link
Collaborator Author

squashed into PR #2101

@dshovchko dshovchko closed this Dec 7, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Dec 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature New feature needs review The PR is waiting for review require squash No action from PR author required. Marks that current PR will be merged with squash
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants