Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(site): replace usages of --100vh hack with dvh units #2211

Merged
merged 3 commits into from
Feb 6, 2024

Conversation

fshovchko
Copy link
Contributor

@fshovchko fshovchko commented Feb 1, 2024

Closes #2208

@fshovchko fshovchko marked this pull request as ready for review February 5, 2024 17:21
@fshovchko fshovchko requested review from a team, dshovchko, julia-murashko and NastaLeo and removed request for a team February 5, 2024 18:03
@ala-n ala-n added the site Feature, enhancement or bug for demo site label Feb 6, 2024
Copy link

codeclimate bot commented Feb 6, 2024

Code Climate has analyzed commit e9c7da2 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 64.6% (0.0% change).

View more on Code Climate.

@ala-n ala-n merged commit 7194504 into main Feb 6, 2024
7 checks passed
@ala-n ala-n deleted the site/replace-vsize-proxy branch February 6, 2024 12:48
@github-actions github-actions bot locked and limited conversation to collaborators Feb 6, 2024
@ala-n
Copy link
Collaborator

ala-n commented Feb 14, 2024

🎉 This PR is included in version 5.0.0-beta.10 🎉

The release is available on:

Your semantic-release bot 📦🚀

@ala-n
Copy link
Collaborator

ala-n commented Apr 5, 2024

🎉 This PR is included in version 4.15.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@ala-n ala-n added the released label Apr 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
released on @beta released site Feature, enhancement or bug for demo site
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[site]: replace usages of --100vh hack via modern dvh units
4 participants