Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: migration guide update according actual state #2820

Merged
merged 2 commits into from
Dec 12, 2024
Merged

docs: migration guide update according actual state #2820

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dcbd52e
docs: migration guide update according actual state
ala-n Dec 12, 2024
467e61c
docs: fix review comments
ala-n Dec 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions site/views/blogs/ESL v5.0.0 Migartion Guide.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,10 +57,15 @@ The points not marked with `🔧` in the breaking changes section are covered by
Note that `activator` property change now is the part of main toggleable flow.
- `this.open` of Toggleables doesn't update until super.onShow/super.onHide is called.
Make sure you update `this.open` synchronously or manually notify consumers in case the super call of `onShow/onHide` should be postponed.
- #### A11y improvements and focus management (affects ESlPopup)
- `a11y` option introduced and now used to control the focus management and a11y for `esl-popup`, `esl-tooltip` (footnotes), `esl-share`, `esl-select` (dropdown).
Option available on `ESLToggleable` level and controls focus flow and close on outside action feature.
- #### ESL Triggers API Changes
- `ESLTrigger` does not have target defined to `::next` by default. You should always define the target explicitly.
- #### ESL Panel and Panel Group
- `fallback-duration` is no longer in the JSX shape of `ESLPanel` and `ESLPanelGroup`.
- #### ESL Popup
- Attribute `disable-arrow` no longer supported. Use class `disable-arrow` instead.

- ### ESL Footnotes
- `ESLNote` now based on `ESLBaseTrigger` so active marker now called `active` instead of `tooltip-shown`.
Expand Down
Loading