-
Notifications
You must be signed in to change notification settings - Fork 345
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multiple options to language code in file name #98
base: master
Are you sure you want to change the base?
Conversation
Update upstream
I realize that I have not explained how it works, for do some test. It's really easy, in the configuration there is an option 'Display language code in file name'. That combo had two values 'No' (default) or 'Yes', now I open that and I put three values 'No' (default), 'Yes (2 chars)' and 'Yes (3 chars). So It's really easy as I said, if have any question can ask me. |
hi, please resolve the conflicts and i'll merge it to my fork |
Hi Ariel, What are you going to do with this plugin? |
I figured out that since there are so many nice pull requests to https://github.com/exebetche/vlsub but none is merged, I can fork and merge them. Seems like the original repo is kind of abandoned and unresponsive. |
Hi, today I myself discovered the handy plugin I too would prefer to rename files to the 2 letter code (ISO 639-1) instead of the 3 letter code (ISO 639-2). Configuration > Display language code in file name: As of this version still has only Yes and No, instead of this clever proposal to choose Yes (3 letter codes) and Yes (2 letter codes). Any news on why this pull request was not accepted and did not make it into the official version (as pre-installed in VLC) ? |
I never get any kind of feedback for this PR so I end up using a custom version of the addon with this feature included. |
Hello, im doing a modification because i want to select the language code for the file in iso-639-1 or iso-639-3. For example i need to use the extension .es.srt instead of .spa.srt.
Now I think that is working fine.