Jupyterbook on GitHub Pages directly from action #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for submitting your first pull request! You are awesome! 🤗 |
|
@agoose77 : Ready for review now! :) |
|
@kolibril13 thank you for this PR! I appreciate your patience whilst I got around to this. |
|
Congrats on your first merged pull request in this project! 🎉 |
2 tasks
|
Thanks @kolibril13! Looks like we're done here 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With these changes, bringing a JupyterBook to GitHub pages is simply:
activate "Deploy from GitHub actions", no need for a gh-pages branch anymore.
Follow-Up to this discussion on the Myst Markdown Discord:
https://discord.com/channels/1083088970059096114/1083088970059096117/1158825259315777600
The new workflow was tested here:
https://github.com/kolibril13/jupyterbook-directly-from-action
cc. @agoose77