Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add basthon launch button #595

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

fortierq
Copy link

@fortierq fortierq commented Jul 24, 2022

This PR adds a launch button for Basthon.

Basthon is a nice project to execute a notebook client-side (inside the browser), using Pyodide. Similar to Jupyterlite, but I found it more stable and usable with several languages (SQL, OCaml...).

To do

  • Get a square logo from @casatir
  • Take another pass through the docs text
  • Make sure it works as-expected

@fortierq
Copy link
Author

Cleaned git history.

Copy link
Member

@choldgraf choldgraf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't used Basthon before but it seems reasonable to me. We might change up the way that launch buttons are added in the future but this seems fine to add in the meantime. One quick question about the logo image though

docs/launch.md Outdated Show resolved Hide resolved
src/sphinx_book_theme/header_buttons/launch.py Outdated Show resolved Hide resolved
@choldgraf
Copy link
Member

Found an image

Reviving this one from the dead :-D

I spoke with @casatir and he will create an SVG version of the b and the t from Basthon for use as a little square logo.

@casatir
Copy link

casatir commented Dec 9, 2022

Hi there,

Thanks for using Basthon! Here it is.

@fortierq
Copy link
Author

I tried to fix the tests, but after merging from the master branch, I get those errors :

E           sphinx.errors.ThemeError: An error happened in rendering the page index.
E           Reason: KeyError('https://google.com')

PS : @casatir , did you see my PR for Basthon (https://framagit.org/basthon/basthon-notebook/-/merge_requests/1) ?

Co-authored-by: Chris Holdgraf <[email protected]>
Co-authored-by: Angus Hollands <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants