Refactor dot-dsl tests#1588
Conversation
|
This PR touches files which potentially affect the outcome of the tests of an exercise. This will cause all students' solutions to affected exercises to be re-tested. If this PR does not affect the result of the test (or, for example, adds an edge case that is not worth rerunning all tests for), please add the following to the merge-commit message which will stops student's tests from re-running. Please copy-paste to avoid typos. For more information, refer to the documentation. If you are unsure whether to add the message or not, please ping |
|
Thank you for contributing to Based on the files changed in this PR, it would be good to pay attention to the following details when reviewing the PR:
Automated comment created by PR Commenter 🤖. |
Changes inspired by this forum post: https://forum.exercism.org/t/dot-dsl-duplicate-test/18938
Note that this exercise doesn't have canonical data.
What I have done:
invalid statement: graph with no keywordsto usegraph()in the graph, notEnum.map()graph [foo: "bar"]is no longer encouraged in Elixir. It got automatically reformatted to a regular call with parenthesis in this giga PR: 771a49c#diff-ebb08554f0f8f470024408d2abdabaa480671a429f693afe56cc86eff923b1e4 In the same PR, the syntax "without space" got changes fromgraph[foo: "bar"]tograph[[foo: "bar"]]. WIth autoformatting, it no longer makes sense to talk about "with spaces" or "without spaces". I renamed those tests to "not a call".