Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change linter command for CI #470

Merged
merged 1 commit into from
May 10, 2021
Merged

Change linter command for CI #470

merged 1 commit into from
May 10, 2021

Conversation

dector
Copy link
Member

@dector dector commented May 9, 2021 •
edited
Loading

Seems like new configlet should be run as configlet lint but currently it's used as configlet lint ..

CI check will still fail but not because of Gradle. I'm checking it too (#471).

@dector dector mentioned this pull request May 9, 2021
Open
@dector dector requested a review from ErikSchierboom May 9, 2021 12:28
ErikSchierboom
ErikSchierboom approved these changes May 10, 2021
View reviewed changes
Copy link
Member

@ErikSchierboom ErikSchierboom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is indeed a breaking change that we introduced. Sorry about that.

@dector
Copy link
Member Author

dector commented May 10, 2021

@ErikSchierboom not a big deal. I think we can remove linter from Travis CI later as we have it in GitHub Actions.

@dector dector merged commit abca9fb into main May 10, 2021
@dector dector deleted the fix-linter branch May 10, 2021 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ErikSchierboom ErikSchierboom ErikSchierboom approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dector @ErikSchierboom