Skip to content

Conversation

remyrd
Copy link

@remyrd remyrd commented Sep 1, 2025

Description

Add support for Kubernetes Audit - Create / Update / Read

Checklist

(For exoscale contributors)

  • Changelog updated (under Unreleased block)
  • Acceptance tests OK
  • For a new resource, datasource or new attributes: acceptance test added/updated

Testing

@nerzhul nerzhul self-assigned this Sep 23, 2025
Copy link
Author

@remyrd remyrd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not an expert here but so far looks good to me. The only detail worth mentioning is when updating the cluster, the abscence of an audit config in the payload ⚠️ does not ⚠️ disable it. The user has to explicitly set enabled: false

@kobajagi
Copy link
Contributor

I'm not an expert here but so far looks good to me. The only detail worth mentioning is when updating the cluster, the abscence of an audit config in the payload ⚠️ does not ⚠️ disable it. The user has to explicitly set enabled: false

That is expected behavior of an optional attribute in terraform. Adding a note never hurts.

@nerzhul nerzhul force-pushed the remy/sc-135074/sks-audit-log-webhook branch from 2799ff4 to 2fc00d9 Compare September 26, 2025 14:49
@nerzhul nerzhul force-pushed the remy/sc-135074/sks-audit-log-webhook branch from 2fc00d9 to 0e499a3 Compare September 26, 2025 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants