fix: add suppressHydrationWarning when using nonce and disableNextScript #184
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
merge pls!! |
|
BUMP please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem
When using disableNextScript and a nonce at the same time, React complains about a hydration mismatch between a nonce parameter with some value on the server, and a nonce value of "" in the client.
The cause
Nonces are removed by the browser from DOM elements to prevent them from being exposed to client side code. This happens before React hydrates the page, so it causes a mismatch.
The fix
Set suppressHydrationWarning on the vanilla script tag if nonce is being used.