Skip to content

Fix typos #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix typos #57

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
* **BREAKING CHANGE** Drop support for Rails 5.1
* **BREAKING CHANGE** Removed deprecated methods
* Fix Rails 6 deprecation warnings
* Add offical support for Rails 6.1
* Add official support for Rails 6.1

## 1.4.0 - July 10, 2019
* **BREAKING CHANGE** drop support for rails 4.1
Expand Down
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,7 +167,7 @@ end
## Caveats

1. This will only work on associations that are dependent destroy. It
should be trival to change that or make it optional.
should be trivial to change that or make it optional.
1. If you would like to work on this, you will need to setup sqlite on your development machine. Alternately, you can disable specific dev dependencies in the gemspec and test_helper and ask for help.

## Testing
Expand Down
2 changes: 1 addition & 1 deletion test/relations_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ class RelationsTest < ActiveSupport::TestCase
assert parents.first.archivals.last.archived?
end

test "unarchive_all! unarchives all records in an AR Assocation" do
test "unarchive_all! unarchives all records in an AR Association" do
3.times { Archival.create! }

archivals = Archival.all
Expand Down