Add parameter validation to prevent silent failures #2186
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds parameter validation to the LanguageModel class to warn users about invalid or misspelled parameters that will be silently ignored.
Fixes #2184
Problem
Currently, EDSL accepts any parameter without validation, leading to silent failures when users:
temprature
instead oftemperature
)unicorn_mode=True
)Solution
Added a parameter validation system that:
Changes
parameter_validator.py
with validation logic and known parameters for each servicelanguage_model.py
to validate kwargs before applying themtest_parameter_validation.py
Example
Testing
Backward Compatibility