[build-tools] respect modifications made by pre install hook when reading package.json
#365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ding `package.json`
szdziedzic
changed the title
package.json
sjchmiela
approved these changes
Mar 14, 2024
szdziedzic
deleted the
@szdziedzic/respect-modifications-made-by-pre-install-hook-when-reading-package-json
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
expo/eas-cli#2267
"This seems to be an issue with the nx-generator so maybe this issue can be closed, but it seems that the build agent output for the Read package.json step should respect that the pre-install hook changed the file which it currently does not seem to do."
How
Read
package.jsonduringRead package.jsonstep