Skip to content

Commit

Permalink
[ENG-9772][eas-cli] don't ask user to install dev client if running i…
Browse files Browse the repository at this point in the history
…n non-interactive mode (#2124)

* [eas-cli] don't ask user to install dev client if running in non ineractive mode

* update CHANGELOG.md
  • Loading branch information
szdziedzic authored Nov 17, 2023
1 parent a541a2e commit 50d78b0
Show file tree
Hide file tree
Showing 2 changed files with 15 additions and 0 deletions.
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,8 @@ This is the log of notable changes to EAS CLI and related packages.

### 🐛 Bug fixes

- Don't ask a user to install the dev client if running in non-interactive mode. ([#2124](https://github.com/expo/eas-cli/pull/2124) by [@szdziedzic](https://github.com/szdziedzic))

### 🧹 Chores

## [5.9.0](https://github.com/expo/eas-cli/releases/tag/v5.9.0) - 2023-11-15
Expand Down
13 changes: 13 additions & 0 deletions packages/eas-cli/src/build/utils/devClient.ts
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,19 @@ export async function ensureExpoDevClientInstalledForDevClientBuildsAsync({
'expo-dev-client'
)} installed for your project.`
);
if (nonInteractive) {
Log.error(`You'll need to install ${chalk.bold('expo-dev-client')} manually.`);
Log.error(
learnMore('https://docs.expo.dev/clients/installation/', {
learnMoreMessage: 'See installation instructions on how to do it.',
dim: false,
})
);
Errors.error(`Install ${chalk.bold('expo-dev-client')} manually and try again later.`, {
exit: 1,
});
}

const areAllManaged = workflowPerPlatformList.every(i => i === Workflow.MANAGED);
if (areAllManaged) {
const install = await confirmAsync({
Expand Down

0 comments on commit 50d78b0

Please sign in to comment.