-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EAS build fails from nx-monorepo due to missing dependencies, yet hook that should fix package.json runs without issues #2267
Comments
Issue open on nx: nrwl/nx#22195 |
It appears that the This seems to be an issue with the nx-generator so maybe this issue can be closed, but it seems that the build agent output for the Read package.json step should respect that the pre-install hook changed the file which it currently does not seem to do.
Add {
"name": "nx-expo-test",
"version": "0.0.1",
"private": true,
"dependencies": {
"@testing-library/jest-native": "*",
"@testing-library/react-native": "*",
"metro-config": "*",
"react-native": "*",
"expo": "*",
"react-native-svg": "*",
"react-native-web": "*"
},
"scripts": {
"eas-build-pre-install": "cd ../../ && node tools/scripts/eas-build-pre-install.mjs . apps/nx-expo-test && cp pnpm-lock.yaml apps/nx-expo-test && cp .npmrc apps/nx-expo-test",
"eas-build-post-install": "cd ../../ && node tools/scripts/eas-build-post-install.mjs . apps/nx-expo-test"
}
} |
Hey, I think you are right, the build agent output for the Read package.json step should respect that the pre-install hook changed the file 👍 |
Thank you for filing this issue! |
Should be fixed now |
@szdziedzic same is happening for projects generated with nx/react-native preset |
Build/Submit details page URL
https://expo.dev/accounts/thomas.rudfoss/projects/nx-expo-test/builds/6d89456f-b009-4a08-add9-ac1cb8cabeb0
Summary
Created a new nx monorepo with the official expo plugin. The app runs fine during development, but eas build fails apparently because dependencies cannot be properly installed.
Nx comes with pre and post install hooks that should update the
package.json
file to include the necessary dependencies, but based on the Read package.json step output this does not seem to take effect even though the pre/post hook steps report no issues.Managed or bare?
managed
Environment
Error output
No response
Reproducible demo or steps to reproduce from a blank project
Fully reproducible repo here: https://github.com/rudfoss/nx-expo-test
The text was updated successfully, but these errors were encountered: