-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[eas-cli] Upgrade packages from the expo/expo repo #2145
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wschurman
force-pushed
the
@wschurman/trial-upgrade-packages
branch
2 times, most recently
from
January 5, 2024 00:00
92adc6d
to
1855de2
Compare
/changelog-entry chore Upgrade packages from the expo/expo repo |
wschurman
requested review from
EvanBacon,
byCedric,
szdziedzic and
khamilowicz
as code owners
January 5, 2024 00:03
wschurman
requested review from
quinlanj
and removed request for
khamilowicz and
EvanBacon
January 5, 2024 00:03
Size Change: +1.26 MB (+2%) Total Size: 51.5 MB
|
szdziedzic
approved these changes
Jan 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks reasonable
quinlanj
approved these changes
Jan 8, 2024
wschurman
force-pushed
the
@wschurman/trial-upgrade-packages
branch
2 times, most recently
from
January 18, 2024 17:14
1b77c16
to
d38c666
Compare
wschurman
force-pushed
the
@wschurman/trial-upgrade-packages
branch
from
January 18, 2024 17:21
d38c666
to
daaa206
Compare
✅ Thank you for adding the changelog entry! |
Re-tested, landing now that these versions of the packages are marked as latest. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
This PR upgrades the packages in eas-cli from the upcoming SDK release. I don't plan to land this until the package versions are finalized (beta is done), at which time I'll set these versions to the production ones.
Depends on expo/expo#25874.
Closes ENG-9845.
How
Upgrade packages, fix tsc.
This removes classic update validation from eas-cli since it no longer exists in the types.
Test Plan
Run tests.