Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[eas-cli] Upgrade packages from the expo/expo repo #2145

Merged
merged 1 commit into from
Jan 18, 2024

Conversation

wschurman
Copy link
Member

@wschurman wschurman commented Dec 12, 2023

Why

This PR upgrades the packages in eas-cli from the upcoming SDK release. I don't plan to land this until the package versions are finalized (beta is done), at which time I'll set these versions to the production ones.

Depends on expo/expo#25874.

Closes ENG-9845.

How

Upgrade packages, fix tsc.

This removes classic update validation from eas-cli since it no longer exists in the types.

Test Plan

Run tests.

neas init
neas update:configure
neas build
neas update

Copy link

linear bot commented Dec 12, 2023

@wschurman wschurman force-pushed the @wschurman/trial-upgrade-packages branch 2 times, most recently from 92adc6d to 1855de2 Compare January 5, 2024 00:00
@wschurman
Copy link
Member Author

/changelog-entry chore Upgrade packages from the expo/expo repo

@wschurman wschurman marked this pull request as ready for review January 5, 2024 00:03
@wschurman wschurman requested review from quinlanj and removed request for khamilowicz and EvanBacon January 5, 2024 00:03
Copy link

github-actions bot commented Jan 5, 2024

Size Change: +1.26 MB (+2%)

Total Size: 51.5 MB

Filename Size Change
./packages/eas-cli/dist/eas-linux-x64.tar.gz 51.5 MB +1.26 MB (+2%)

compressed-size-action

Copy link

codecov bot commented Jan 5, 2024

Codecov Report

Attention: 33 lines in your changes are missing coverage. Please review.

Comparison is base (f5a99ce) 54.11% compared to head (daaa206) 54.12%.

Files Patch % Lines
packages/eas-cli/src/build/android/version.ts 0.00% 4 Missing ⚠️
packages/eas-cli/src/build/ios/version.ts 0.00% 4 Missing ⚠️
packages/eas-cli/src/update/configure.ts 33.34% 4 Missing ⚠️
...ckages/eas-cli/src/update/android/UpdatesModule.ts 0.00% 3 Missing ⚠️
...-cli/src/build/android/syncProjectConfiguration.ts 33.34% 2 Missing ⚠️
.../eas-cli/src/build/ios/syncProjectConfiguration.ts 33.34% 2 Missing ⚠️
packages/eas-cli/src/build/metadata.ts 0.00% 2 Missing ⚠️
packages/eas-cli/src/commands/build/configure.ts 33.34% 2 Missing ⚠️
...kages/eas-cli/src/rollout/actions/CreateRollout.ts 0.00% 2 Missing ⚠️
packages/eas-cli/src/update/ios/UpdatesModule.ts 0.00% 2 Missing ⚠️
... and 6 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2145      +/-   ##
==========================================
+ Coverage   54.11%   54.12%   +0.02%     
==========================================
  Files         516      516              
  Lines       18815    18792      -23     
  Branches     3771     3768       -3     
==========================================
- Hits        10179    10170       -9     
+ Misses       8615     8601      -14     
  Partials       21       21              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@szdziedzic szdziedzic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable

@wschurman wschurman force-pushed the @wschurman/trial-upgrade-packages branch 2 times, most recently from 1b77c16 to d38c666 Compare January 18, 2024 17:14
@wschurman wschurman force-pushed the @wschurman/trial-upgrade-packages branch from d38c666 to daaa206 Compare January 18, 2024 17:21
Copy link

✅ Thank you for adding the changelog entry!

@wschurman
Copy link
Member Author

Re-tested, landing now that these versions of the packages are marked as latest.

@wschurman wschurman merged commit ea57d63 into main Jan 18, 2024
9 checks passed
@wschurman wschurman deleted the @wschurman/trial-upgrade-packages branch January 18, 2024 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants