-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[eas-cli][eas-update] Allow undefined update message #2148
Conversation
/changelog-entry new-feature Allow undefined update message for EAS Update publishing |
Size Change: -488 B (0%) Total Size: 55.5 MB
|
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #2148 +/- ##
==========================================
- Coverage 54.22% 54.21% -0.00%
==========================================
Files 509 509
Lines 18663 18670 +7
Branches 3737 3741 +4
==========================================
+ Hits 10119 10121 +2
- Misses 8523 8528 +5
Partials 21 21 ☔ View full report in Codecov by Sentry. |
Most of our UI's and tooling rely on people to provide a message to be usable, and we assume most people are using some kind of VCS. No VCS would be a bad user experience, but in the absence of a VCS, we should not be blocking people from publishing. |
That's a good point. Maybe we should only allow this to be empty when there's no VCS? |
952e590
to
21d0fa7
Compare
/changelog-entry new-feature Allow undefined update message for EAS Update publishing when no VCS |
✅ Thank you for adding the changelog entry! |
Why
This was requested for cases where there isn't a VCS and also no update message is manually supplied.
Closes ENG-9633.
How
It is already optional in the GraphQL mutation, so this is just a product decision that we need to deliberately make.
For Reviewers
I think it's worth having a discussion on the UX benefits/costs of this product decision. This PR is meant to just start the discussion, not convey a strong intent to make the change as I'm probably oblivious to potential downsides.
Test Plan
Create an update and don't specify message.