Skip to content

[ci] auto update EAS CLI version used on production for builds triggered using GitHub trigger #2211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

szdziedzic
Copy link
Contributor

Why

https://exponent-internal.slack.com/archives/CRM0Y8JLU/p1706823546329859?thread_ts=1706822844.405259&cid=CRM0Y8JLU

It's super easy to forget about it and prod version is getting out of sync

How

Bump the latest-eas-build tag (the tag determining which EAS CLI version used for GH builds on prod) automatically after publishing the release

@szdziedzic szdziedzic requested a review from FiberJW February 1, 2024 21:50
@szdziedzic szdziedzic added the no changelog PR that doesn't require a changelog entry label Feb 1, 2024
Copy link

github-actions bot commented Feb 1, 2024

⏩ The changelog entry check has been skipped since the "no changelog" label is present.

Copy link

github-actions bot commented Feb 1, 2024

Size Change: +298 B (0%)

Total Size: 51.5 MB

Filename Size Change
./packages/eas-cli/dist/eas-linux-x64.tar.gz 51.5 MB +298 B (0%)

compressed-size-action

Copy link

codecov bot commented Feb 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (204a8b7) 54.16% compared to head (69fcfab) 54.16%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2211   +/-   ##
=======================================
  Coverage   54.16%   54.16%           
=======================================
  Files         516      516           
  Lines       18805    18805           
  Branches     3968     3968           
=======================================
  Hits        10183    10183           
  Misses       7931     7931           
  Partials      691      691           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@FiberJW FiberJW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Conceptually this makes sense to me, but I don't have enough context on the release workflow to request any code changes

@szdziedzic szdziedzic merged commit 9ee9ea3 into main Feb 1, 2024
@szdziedzic szdziedzic deleted the @szdziedzic/auto-update-eas-cli-version-used-on-prod-for-gh-builds branch February 1, 2024 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no changelog PR that doesn't require a changelog entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants